From 254efd7841bc8f127694642c49b204fdb5add9a5 Mon Sep 17 00:00:00 2001
From: theturtlemafia <theturtlemafia@gmail.com>
Date: Sat, 9 Aug 2025 19:23:47 -0400
Subject: [PATCH] implement feedback

---
 include/card.h          | 2 ++
 include/graphic_utils.h | 1 +
 source/joker.c          | 8 ++++----
 source/joker_effects.c  | 2 +-
 4 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/include/card.h b/include/card.h
index 2b003b6..9831013 100644
--- a/include/card.h
+++ b/include/card.h
@@ -35,6 +35,8 @@
 #define NUM_RANKS 13
 #define RANK_OFFSET 2 // Because the first rank is 2 and ranks start at 0
 
+#define IMPOSSIBLY_HIGH_CARD_VALUE 99
+
 // Card types
 typedef struct
 {
diff --git a/include/graphic_utils.h b/include/graphic_utils.h
index 6c169c7..be20b1a 100644
--- a/include/graphic_utils.h
+++ b/include/graphic_utils.h
@@ -42,6 +42,7 @@
 
 // Tile size in pixels, both height and width as tiles are square
 #define TILE_SIZE 8
+#define EFFECT_TEXT_SEPARATION_AMOUNT 32; // If we need to show multiple effects at once
 
 typedef struct
 {
diff --git a/source/joker.c b/source/joker.c
index 8dc6573..3ae8a7a 100644
--- a/source/joker.c
+++ b/source/joker.c
@@ -243,7 +243,7 @@ bool joker_object_score(JokerObject *joker_object, Card* scored_card, int *chips
             tte_set_special(0xD000); // Blue
             snprintf(score_buffer, sizeof(score_buffer), "+%d", joker_effect.chips);
             tte_write(score_buffer);
-            cursorPosX += 30;
+            cursorPosX += EFFECT_TEXT_SEPARATION_AMOUNT;
         }
         if (joker_effect.mult > 0)
         {
@@ -252,7 +252,7 @@ bool joker_object_score(JokerObject *joker_object, Card* scored_card, int *chips
             tte_set_special(0xE000); // Red
             snprintf(score_buffer, sizeof(score_buffer), "+%d", joker_effect.mult);
             tte_write(score_buffer);
-            cursorPosX += 30;
+            cursorPosX += EFFECT_TEXT_SEPARATION_AMOUNT;
         }
         if (joker_effect.xmult > 0)
         {
@@ -261,7 +261,7 @@ bool joker_object_score(JokerObject *joker_object, Card* scored_card, int *chips
             tte_set_special(0xE000); // Red
             snprintf(score_buffer, sizeof(score_buffer), "X%d", joker_effect.xmult);
             tte_write(score_buffer);
-            cursorPosX += 30;
+            cursorPosX += EFFECT_TEXT_SEPARATION_AMOUNT;
         }
         if (joker_effect.money > 0)
         {
@@ -270,7 +270,7 @@ bool joker_object_score(JokerObject *joker_object, Card* scored_card, int *chips
             tte_set_special(0xC000); // Yellow
             snprintf(score_buffer, sizeof(score_buffer), "+%d", joker_effect.money);
             tte_write(score_buffer);
-            cursorPosX += 30;
+            cursorPosX += EFFECT_TEXT_SEPARATION_AMOUNT;
         }
 
         joker_object->joker->processed = true; // Mark the joker as processed
diff --git a/source/joker_effects.c b/source/joker_effects.c
index c9aa15b..df434f4 100644
--- a/source/joker_effects.c
+++ b/source/joker_effects.c
@@ -304,7 +304,7 @@ static JokerEffect raised_fist_joker_effect(Joker *joker, Card *scored_card) {
 
     // Find the lowest rank card in hand
     // Aces are always considered high value, even in an ace-low straight
-    u8 lowest_value = 99;
+    u8 lowest_value = IMPOSSIBLY_HIGH_CARD_VALUE;
     CardObject** hand = get_hand_array();
     int hand_top = get_hand_top();
     for (int i = 0; i < hand_top; i++ )