From 023e4c5514e2f4dcf82f63b8a88135c634c13b50 Mon Sep 17 00:00:00 2001
From: xintaofei <itpkcn@gmail.com>
Date: Sun, 12 Apr 2026 11:56:55 +0800
Subject: [PATCH] fix(acp): pin @latest for all plugins and enable button when
 only floating versions exist

- install_missing_plugins now pins ALL @latest specs (not just newly installed)
- When nothing is missing but @latest exists, the pin-only path runs
- Modal button switches to 'Pin @latest Versions' when no missing plugins
- Added pinVersions i18n key for 10 languages
---
 src-tauri/src/acp/opencode_plugins.rs         | 49 ++++++++++++++++---
 .../settings/opencode-plugins-modal.tsx       | 10 +++-
 src/i18n/messages/ar.json                     |  1 +
 src/i18n/messages/de.json                     |  1 +
 src/i18n/messages/en.json                     |  1 +
 src/i18n/messages/es.json                     |  1 +
 src/i18n/messages/fr.json                     |  1 +
 src/i18n/messages/ja.json                     |  1 +
 src/i18n/messages/ko.json                     |  1 +
 src/i18n/messages/pt.json                     |  1 +
 src/i18n/messages/zh-CN.json                  |  1 +
 src/i18n/messages/zh-TW.json                  |  1 +
 12 files changed, 60 insertions(+), 9 deletions(-)

diff --git a/src-tauri/src/acp/opencode_plugins.rs b/src-tauri/src/acp/opencode_plugins.rs
index c8bb7d5..dc8a9ca 100644
--- a/src-tauri/src/acp/opencode_plugins.rs
+++ b/src-tauri/src/acp/opencode_plugins.rs
@@ -435,12 +435,44 @@ pub async fn install_missing_plugins(
         .collect();
 
     if missing.is_empty() {
-        emit_plugin_event(
-            emitter,
-            &task_id,
-            PluginInstallEventKind::Completed,
-            "Nothing to install — all plugins are already present",
-        );
+        // Nothing to install, but still pin any @latest specs
+        let all_specs: Vec<(String, String)> = summary
+            .plugins
+            .iter()
+            .map(|p| (p.name.clone(), p.declared_spec.clone()))
+            .collect();
+        match pin_latest_specs(&summary.config_path, &summary.cache_dir, &all_specs) {
+            Ok(n) if n > 0 => {
+                emit_plugin_event(
+                    emitter,
+                    &task_id,
+                    PluginInstallEventKind::Log,
+                    format!("Pinned {n} @latest plugin(s) to installed versions in opencode.json"),
+                );
+                emit_plugin_event(
+                    emitter,
+                    &task_id,
+                    PluginInstallEventKind::Completed,
+                    format!("Pinned {n} @latest plugin(s) — no missing plugins to install"),
+                );
+            }
+            Err(e) => {
+                emit_plugin_event(
+                    emitter,
+                    &task_id,
+                    PluginInstallEventKind::Failed,
+                    format!("Failed to pin @latest versions: {e}"),
+                );
+            }
+            _ => {
+                emit_plugin_event(
+                    emitter,
+                    &task_id,
+                    PluginInstallEventKind::Completed,
+                    "Nothing to install — all plugins are already present",
+                );
+            }
+        }
         return Ok(());
     }
 
@@ -518,7 +550,10 @@ pub async fn install_missing_plugins(
     if exit_status.success() {
         // Pin @latest specs to actual installed versions to avoid
         // opencode hitting the npm registry on every startup.
-        let spec_pairs: Vec<(String, String)> = missing
+        // Pin ALL plugins (not just the ones we installed), so already-installed
+        // @latest plugins also get pinned.
+        let spec_pairs: Vec<(String, String)> = summary
+            .plugins
             .iter()
             .map(|p| (p.name.clone(), p.declared_spec.clone()))
             .collect();
diff --git a/src/components/settings/opencode-plugins-modal.tsx b/src/components/settings/opencode-plugins-modal.tsx
index 90cd4af..30c7d8c 100644
--- a/src/components/settings/opencode-plugins-modal.tsx
+++ b/src/components/settings/opencode-plugins-modal.tsx
@@ -117,6 +117,10 @@ export function OpencodePluginsModal({
 
   const missingCount =
     summary?.plugins.filter((p) => p.status === "missing").length ?? 0
+  const floatingCount =
+    summary?.plugins.filter((p) => p.declared_spec.endsWith("@latest"))
+      .length ?? 0
+  const hasActionablePlugins = missingCount > 0 || floatingCount > 0
 
   return (
     <Dialog open={open} onOpenChange={handleClose}>
@@ -209,7 +213,7 @@ export function OpencodePluginsModal({
             <div className="flex items-center justify-between">
               <Button
                 size="sm"
-                disabled={isOperating || missingCount === 0}
+                disabled={isOperating || !hasActionablePlugins}
                 onClick={handleInstallAll}
               >
                 {stream.status === "running" ? (
@@ -217,7 +221,9 @@ export function OpencodePluginsModal({
                 ) : (
                   <Download className="h-3.5 w-3.5 mr-1.5" />
                 )}
-                {t("opencodePlugins.installAll")}
+                {missingCount > 0
+                  ? t("opencodePlugins.installAll")
+                  : t("opencodePlugins.pinVersions")}
               </Button>
               <Button
                 size="sm"
diff --git a/src/i18n/messages/ar.json b/src/i18n/messages/ar.json
index a8a508a..f2acd3b 100644
--- a/src/i18n/messages/ar.json
+++ b/src/i18n/messages/ar.json
@@ -695,6 +695,7 @@
         "missing": "غير مثبّت"
       },
       "installAll": "تثبيت جميع الإضافات المفقودة",
+      "pinVersions": "تثبيت إصدارات @latest",
       "install": "تثبيت",
       "uninstall": "إزالة",
       "refresh": "تحديث",
diff --git a/src/i18n/messages/de.json b/src/i18n/messages/de.json
index 34da1c2..46cd29e 100644
--- a/src/i18n/messages/de.json
+++ b/src/i18n/messages/de.json
@@ -695,6 +695,7 @@
         "missing": "Nicht installiert"
       },
       "installAll": "Alle fehlenden installieren",
+      "pinVersions": "@latest-Versionen fixieren",
       "install": "Installieren",
       "uninstall": "Deinstallieren",
       "refresh": "Aktualisieren",
diff --git a/src/i18n/messages/en.json b/src/i18n/messages/en.json
index 2daf012..1c8d77a 100644
--- a/src/i18n/messages/en.json
+++ b/src/i18n/messages/en.json
@@ -695,6 +695,7 @@
         "missing": "Missing"
       },
       "installAll": "Install All Missing",
+      "pinVersions": "Pin @latest Versions",
       "install": "Install",
       "uninstall": "Uninstall",
       "refresh": "Refresh",
diff --git a/src/i18n/messages/es.json b/src/i18n/messages/es.json
index 2c7ba9d..ac84aec 100644
--- a/src/i18n/messages/es.json
+++ b/src/i18n/messages/es.json
@@ -695,6 +695,7 @@
         "missing": "No instalado"
       },
       "installAll": "Instalar todos los faltantes",
+      "pinVersions": "Fijar versiones @latest",
       "install": "Instalar",
       "uninstall": "Desinstalar",
       "refresh": "Actualizar",
diff --git a/src/i18n/messages/fr.json b/src/i18n/messages/fr.json
index 365c92a..c080d75 100644
--- a/src/i18n/messages/fr.json
+++ b/src/i18n/messages/fr.json
@@ -695,6 +695,7 @@
         "missing": "Non installé"
       },
       "installAll": "Installer tous les manquants",
+      "pinVersions": "Fixer les versions @latest",
       "install": "Installer",
       "uninstall": "Désinstaller",
       "refresh": "Actualiser",
diff --git a/src/i18n/messages/ja.json b/src/i18n/messages/ja.json
index a67fa65..c6a69c1 100644
--- a/src/i18n/messages/ja.json
+++ b/src/i18n/messages/ja.json
@@ -695,6 +695,7 @@
         "missing": "未インストール"
       },
       "installAll": "不足プラグインをすべてインストール",
+      "pinVersions": "@latest バージョンを固定",
       "install": "インストール",
       "uninstall": "アンインストール",
       "refresh": "更新",
diff --git a/src/i18n/messages/ko.json b/src/i18n/messages/ko.json
index d071e4b..d50f148 100644
--- a/src/i18n/messages/ko.json
+++ b/src/i18n/messages/ko.json
@@ -695,6 +695,7 @@
         "missing": "미설치"
       },
       "installAll": "누락된 플러그인 모두 설치",
+      "pinVersions": "@latest 버전 고정",
       "install": "설치",
       "uninstall": "제거",
       "refresh": "새로고침",
diff --git a/src/i18n/messages/pt.json b/src/i18n/messages/pt.json
index d9a5b59..f432c1c 100644
--- a/src/i18n/messages/pt.json
+++ b/src/i18n/messages/pt.json
@@ -695,6 +695,7 @@
         "missing": "Não instalado"
       },
       "installAll": "Instalar todos os ausentes",
+      "pinVersions": "Fixar versões @latest",
       "install": "Instalar",
       "uninstall": "Desinstalar",
       "refresh": "Atualizar",
diff --git a/src/i18n/messages/zh-CN.json b/src/i18n/messages/zh-CN.json
index 02c79fe..5d76048 100644
--- a/src/i18n/messages/zh-CN.json
+++ b/src/i18n/messages/zh-CN.json
@@ -695,6 +695,7 @@
         "missing": "未安装"
       },
       "installAll": "安装全部缺失插件",
+      "pinVersions": "固定 @latest 版本",
       "install": "安装",
       "uninstall": "卸载",
       "refresh": "刷新",
diff --git a/src/i18n/messages/zh-TW.json b/src/i18n/messages/zh-TW.json
index 4da6d84..3c59d03 100644
--- a/src/i18n/messages/zh-TW.json
+++ b/src/i18n/messages/zh-TW.json
@@ -695,6 +695,7 @@
         "missing": "未安裝"
       },
       "installAll": "安裝全部缺失外掛",
+      "pinVersions": "固定 @latest 版本",
       "install": "安裝",
       "uninstall": "解除安裝",
       "refresh": "重新整理",