增强git凭证处理

This commit is contained in:
itpkcn@gmail.com
2026-03-21 12:01:40 +08:00
parent 62fab2c3f2
commit 59327f6e02
3 changed files with 377 additions and 28 deletions

View File

@@ -14,12 +14,38 @@ use tauri::Emitter;
use tokio::sync::Semaphore; use tokio::sync::Semaphore;
use walkdir::WalkDir; use walkdir::WalkDir;
use tauri::Manager;
use crate::app_error::AppCommandError; use crate::app_error::AppCommandError;
use crate::db::error::DbError; use crate::db::error::DbError;
use crate::db::service::folder_service; use crate::db::service::folder_service;
use crate::db::AppDatabase; use crate::db::AppDatabase;
use crate::models::{FolderDetail, FolderHistoryEntry, OpenedConversation}; use crate::models::{FolderDetail, FolderHistoryEntry, OpenedConversation};
/// Inject stored GitHub credentials into a git command for a given repository.
async fn inject_repo_credentials(
cmd: &mut tokio::process::Command,
repo_path: &str,
db: &AppDatabase,
app_handle: &tauri::AppHandle,
) {
if let Ok(data_dir) = app_handle.path().app_data_dir() {
crate::git_credential::try_inject_for_repo(cmd, repo_path, &db.conn, &data_dir).await;
}
}
/// Inject stored GitHub credentials for a clone URL (no repo path yet).
async fn inject_url_credentials(
cmd: &mut tokio::process::Command,
clone_url: &str,
db: &AppDatabase,
app_handle: &tauri::AppHandle,
) {
if let Ok(data_dir) = app_handle.path().app_data_dir() {
crate::git_credential::try_inject_for_url(cmd, clone_url, &db.conn, &data_dir).await;
}
}
#[derive(Debug, Serialize)] #[derive(Debug, Serialize)]
pub struct GitStatusEntry { pub struct GitStatusEntry {
pub status: String, pub status: String,
@@ -409,15 +435,23 @@ pub async fn create_folder_directory(path: String) -> Result<(), AppCommandError
} }
#[tauri::command] #[tauri::command]
pub async fn clone_repository(url: String, target_dir: String) -> Result<(), AppCommandError> { pub async fn clone_repository(
url: String,
target_dir: String,
db: tauri::State<'_, AppDatabase>,
app_handle: tauri::AppHandle,
) -> Result<(), AppCommandError> {
if url.trim().is_empty() || target_dir.trim().is_empty() { if url.trim().is_empty() || target_dir.trim().is_empty() {
return Err(AppCommandError::invalid_input( return Err(AppCommandError::invalid_input(
"Repository URL and target directory are required", "Repository URL and target directory are required",
)); ));
} }
let output = crate::process::tokio_command("git") let mut cmd = crate::process::tokio_command("git");
.args(["clone", &url, &target_dir]) cmd.args(["clone", &url, &target_dir]);
inject_url_credentials(&mut cmd, &url, &db, &app_handle).await;
let output = cmd
.output() .output()
.await .await
.map_err(|e| { .map_err(|e| {
@@ -532,13 +566,19 @@ pub async fn git_init(path: String) -> Result<(), AppCommandError> {
} }
#[tauri::command] #[tauri::command]
pub async fn git_pull(path: String) -> Result<GitPullResult, AppCommandError> { pub async fn git_pull(
path: String,
db: tauri::State<'_, AppDatabase>,
app_handle: tauri::AppHandle,
) -> Result<GitPullResult, AppCommandError> {
let head_before = get_head_hash(&path).await?; let head_before = get_head_hash(&path).await?;
// Step 1: fetch from remote // Step 1: fetch from remote
let fetch_output = crate::process::tokio_command("git") let mut fetch_cmd = crate::process::tokio_command("git");
.args(["fetch"]) fetch_cmd.args(["fetch"]).current_dir(&path);
.current_dir(&path) inject_repo_credentials(&mut fetch_cmd, &path, &db, &app_handle).await;
let fetch_output = fetch_cmd
.output() .output()
.await .await
.map_err(AppCommandError::io)?; .map_err(AppCommandError::io)?;
@@ -701,10 +741,16 @@ pub async fn git_has_merge_head(path: String) -> Result<bool, AppCommandError> {
} }
#[tauri::command] #[tauri::command]
pub async fn git_fetch(path: String) -> Result<String, AppCommandError> { pub async fn git_fetch(
let output = crate::process::tokio_command("git") path: String,
.args(["fetch", "--all"]) db: tauri::State<'_, AppDatabase>,
.current_dir(&path) app_handle: tauri::AppHandle,
) -> Result<String, AppCommandError> {
let mut cmd = crate::process::tokio_command("git");
cmd.args(["fetch", "--all"]).current_dir(&path);
inject_repo_credentials(&mut cmd, &path, &db, &app_handle).await;
let output = cmd
.output() .output()
.await .await
.map_err(AppCommandError::io)?; .map_err(AppCommandError::io)?;
@@ -716,7 +762,11 @@ pub async fn git_fetch(path: String) -> Result<String, AppCommandError> {
} }
#[tauri::command] #[tauri::command]
pub async fn git_push(path: String) -> Result<GitPushResult, AppCommandError> { pub async fn git_push(
path: String,
db: tauri::State<'_, AppDatabase>,
app_handle: tauri::AppHandle,
) -> Result<GitPushResult, AppCommandError> {
let pushed_commits = estimate_push_commit_count(&path).await; let pushed_commits = estimate_push_commit_count(&path).await;
// Check if the current branch has an upstream configured // Check if the current branch has an upstream configured
@@ -741,19 +791,16 @@ pub async fn git_push(path: String) -> Result<GitPushResult, AppCommandError> {
.trim() .trim()
.to_string(); .to_string();
crate::process::tokio_command("git") let mut cmd = crate::process::tokio_command("git");
.args(["push", "--set-upstream", "origin", &branch]) cmd.args(["push", "--set-upstream", "origin", &branch])
.current_dir(&path) .current_dir(&path);
.output() inject_repo_credentials(&mut cmd, &path, &db, &app_handle).await;
.await cmd.output().await.map_err(AppCommandError::io)?
.map_err(AppCommandError::io)?
} else { } else {
crate::process::tokio_command("git") let mut cmd = crate::process::tokio_command("git");
.args(["push"]) cmd.args(["push"]).current_dir(&path);
.current_dir(&path) inject_repo_credentials(&mut cmd, &path, &db, &app_handle).await;
.output() cmd.output().await.map_err(AppCommandError::io)?
.await
.map_err(AppCommandError::io)?
}; };
if !output.status.success() { if !output.status.success() {
@@ -1503,12 +1550,20 @@ pub async fn git_list_remotes(path: String) -> Result<Vec<GitRemote>, AppCommand
} }
#[tauri::command] #[tauri::command]
pub async fn git_fetch_remote(path: String, name: String) -> Result<String, AppCommandError> { pub async fn git_fetch_remote(
let output = crate::process::tokio_command("git") path: String,
.args(["fetch", &name]) name: String,
db: tauri::State<'_, AppDatabase>,
app_handle: tauri::AppHandle,
) -> Result<String, AppCommandError> {
let mut cmd = crate::process::tokio_command("git");
cmd.args(["fetch", &name])
.current_dir(&path) .current_dir(&path)
.env("GIT_TERMINAL_PROMPT", "0") .env("GIT_TERMINAL_PROMPT", "0")
.stdin(std::process::Stdio::null()) .stdin(std::process::Stdio::null());
inject_repo_credentials(&mut cmd, &path, &db, &app_handle).await;
let output = cmd
.output() .output()
.await .await
.map_err(AppCommandError::io)?; .map_err(AppCommandError::io)?;

View File

@@ -0,0 +1,293 @@
use std::path::{Path, PathBuf};
use sea_orm::DatabaseConnection;
use crate::db::service::app_metadata_service;
use crate::models::system::{GitHubAccount, GitHubAccountsSettings};
const GITHUB_ACCOUNTS_KEY: &str = "github_accounts";
/// Ensure the GIT_ASKPASS helper script exists in the app data directory.
/// Returns the path to the script.
pub fn ensure_askpass_script(app_data_dir: &Path) -> std::io::Result<PathBuf> {
#[cfg(unix)]
{
let script_path = app_data_dir.join("git-askpass.sh");
if !script_path.exists() {
let content = r#"#!/bin/sh
case "$1" in
*[Uu]sername*) echo "$CODEG_GIT_USERNAME" ;;
*[Pp]assword*) echo "$CODEG_GIT_PASSWORD" ;;
esac
"#;
std::fs::write(&script_path, content)?;
// Make executable
use std::os::unix::fs::PermissionsExt;
std::fs::set_permissions(&script_path, std::fs::Permissions::from_mode(0o755))?;
}
Ok(script_path)
}
#[cfg(windows)]
{
let script_path = app_data_dir.join("git-askpass.bat");
if !script_path.exists() {
let content = r#"@echo off
echo %1 | findstr /i "username" >nul
if %errorlevel% equ 0 (
echo %CODEG_GIT_USERNAME%
exit /b
)
echo %1 | findstr /i "password" >nul
if %errorlevel% equ 0 (
echo %CODEG_GIT_PASSWORD%
exit /b
)
"#;
std::fs::write(&script_path, content)?;
}
Ok(script_path)
}
}
/// Inject GitHub credentials into a git command via GIT_ASKPASS.
pub fn inject_credentials(
cmd: &mut tokio::process::Command,
username: &str,
token: &str,
askpass_path: &Path,
) {
cmd.env("GIT_ASKPASS", askpass_path)
.env("CODEG_GIT_USERNAME", username)
.env("CODEG_GIT_PASSWORD", token)
.env("GIT_TERMINAL_PROMPT", "0");
}
/// Get the remote URL for the "origin" remote of a repository.
pub async fn get_remote_url(repo_path: &str) -> Option<String> {
let output = crate::process::tokio_command("git")
.args(["remote", "get-url", "origin"])
.current_dir(repo_path)
.output()
.await
.ok()?;
if !output.status.success() {
return None;
}
let url = String::from_utf8_lossy(&output.stdout).trim().to_string();
if url.is_empty() { None } else { Some(url) }
}
/// Extract the hostname from a git remote URL.
///
/// Handles both HTTPS and SSH URLs:
/// - `https://github.com/user/repo.git` → `github.com`
/// - `git@github.com:user/repo.git` → `github.com`
fn extract_host(remote_url: &str) -> Option<String> {
let url = remote_url.trim();
// HTTPS: https://github.com/...
if let Some(after_scheme) = url
.strip_prefix("https://")
.or_else(|| url.strip_prefix("http://"))
{
// Strip optional user@ prefix (e.g. https://user@github.com/...)
let after_at = after_scheme
.find('@')
.map(|i| &after_scheme[i + 1..])
.unwrap_or(after_scheme);
return after_at.split('/').next().map(|h| h.to_lowercase());
}
// SSH: git@github.com:user/repo.git
if let Some(at_pos) = url.find('@') {
let after_at = &url[at_pos + 1..];
return after_at.split(':').next().map(|h| h.to_lowercase());
}
None
}
/// Find the best matching GitHub account for a given remote URL.
///
/// Matching logic:
/// 1. Match by server_url hostname against the remote URL host
/// 2. Fall back to the default account
/// 3. Fall back to the first account
pub fn find_matching_account<'a>(
accounts: &'a [GitHubAccount],
remote_url: &str,
) -> Option<&'a GitHubAccount> {
if accounts.is_empty() {
return None;
}
let remote_host = extract_host(remote_url);
// Try to match by hostname
if let Some(ref host) = remote_host {
let matched = accounts.iter().find(|a| {
let account_host = extract_host(&a.server_url)
.unwrap_or_else(|| a.server_url.trim().trim_end_matches('/').to_lowercase());
account_host == *host
});
if matched.is_some() {
return matched;
}
}
// Fall back to default account
accounts
.iter()
.find(|a| a.is_default)
.or_else(|| accounts.first())
}
/// Load GitHub accounts from the database.
pub async fn load_github_accounts(
conn: &DatabaseConnection,
) -> Option<GitHubAccountsSettings> {
let raw = app_metadata_service::get_value(conn, GITHUB_ACCOUNTS_KEY)
.await
.ok()??;
serde_json::from_str::<GitHubAccountsSettings>(&raw).ok()
}
/// Resolve credentials for a git repository and inject them into the command.
///
/// This is the main entry point: given a repo path and a git command,
/// it finds the matching GitHub account and injects credentials.
/// Returns `true` if credentials were injected.
pub async fn try_inject_for_repo(
cmd: &mut tokio::process::Command,
repo_path: &str,
conn: &DatabaseConnection,
app_data_dir: &Path,
) -> bool {
let settings = match load_github_accounts(conn).await {
Some(s) if !s.accounts.is_empty() => s,
_ => return false,
};
let remote_url = match get_remote_url(repo_path).await {
Some(url) => url,
None => return false,
};
// Only inject for HTTPS URLs (SSH uses keys, not tokens)
if !remote_url.starts_with("https://") && !remote_url.starts_with("http://") {
return false;
}
let account = match find_matching_account(&settings.accounts, &remote_url) {
Some(a) => a,
None => return false,
};
let askpass = match ensure_askpass_script(app_data_dir) {
Ok(p) => p,
Err(_) => return false,
};
inject_credentials(cmd, &account.username, &account.token, &askpass);
true
}
/// Same as `try_inject_for_repo` but for clone operations where
/// we don't have a repo path yet — just a URL.
pub async fn try_inject_for_url(
cmd: &mut tokio::process::Command,
clone_url: &str,
conn: &DatabaseConnection,
app_data_dir: &Path,
) -> bool {
if !clone_url.starts_with("https://") && !clone_url.starts_with("http://") {
return false;
}
let settings = match load_github_accounts(conn).await {
Some(s) if !s.accounts.is_empty() => s,
_ => return false,
};
let account = match find_matching_account(&settings.accounts, clone_url) {
Some(a) => a,
None => return false,
};
let askpass = match ensure_askpass_script(app_data_dir) {
Ok(p) => p,
Err(_) => return false,
};
inject_credentials(cmd, &account.username, &account.token, &askpass);
true
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_extract_host_https() {
assert_eq!(
extract_host("https://github.com/user/repo.git"),
Some("github.com".to_string())
);
assert_eq!(
extract_host("https://user@github.com/user/repo.git"),
Some("github.com".to_string())
);
assert_eq!(
extract_host("https://gitlab.example.com/org/repo"),
Some("gitlab.example.com".to_string())
);
}
#[test]
fn test_extract_host_ssh() {
assert_eq!(
extract_host("git@github.com:user/repo.git"),
Some("github.com".to_string())
);
}
#[test]
fn test_find_matching_account() {
let accounts = vec![
GitHubAccount {
id: "1".into(),
server_url: "https://github.com".into(),
username: "user1".into(),
token: "tok1".into(),
scopes: vec![],
avatar_url: None,
is_default: false,
created_at: String::new(),
},
GitHubAccount {
id: "2".into(),
server_url: "https://gitlab.example.com".into(),
username: "user2".into(),
token: "tok2".into(),
scopes: vec![],
avatar_url: None,
is_default: true,
created_at: String::new(),
},
];
let matched = find_matching_account(&accounts, "https://github.com/org/repo.git");
assert_eq!(matched.unwrap().username, "user1");
let matched = find_matching_account(&accounts, "https://gitlab.example.com/org/repo");
assert_eq!(matched.unwrap().username, "user2");
// Unknown host falls back to default
let matched = find_matching_account(&accounts, "https://unknown.com/repo");
assert_eq!(matched.unwrap().username, "user2");
}
}

View File

@@ -2,6 +2,7 @@ mod acp;
mod app_error; mod app_error;
mod commands; mod commands;
mod db; mod db;
mod git_credential;
mod models; mod models;
mod network; mod network;
mod parsers; mod parsers;