Refactor - remove selected from SpriteObject (#305)

This commit is contained in:
MeirGavish
2025-12-12 18:44:26 -08:00
committed by GitHub
parent 440efe1ce1
commit 9bffe5c9a9
6 changed files with 5 additions and 38 deletions
+1
View File
@@ -51,6 +51,7 @@ typedef struct CardObject
{ {
Card* card; Card* card;
SpriteObject* sprite_object; SpriteObject* sprite_object;
bool selected;
} CardObject; } CardObject;
// Card functions // Card functions
-3
View File
@@ -176,9 +176,6 @@ bool joker_object_score(
enum JokerEvent joker_event enum JokerEvent joker_event
); );
void joker_object_set_selected(JokerObject* joker_object, bool selected);
bool joker_object_is_selected(JokerObject* joker_object);
Sprite* joker_object_get_sprite(JokerObject* joker_object); Sprite* joker_object_get_sprite(JokerObject* joker_object);
int joker_get_random_rarity(); int joker_get_random_rarity();
+1 -4
View File
@@ -18,7 +18,7 @@ typedef struct
int idx; int idx;
} Sprite; } Sprite;
// A sprite object is a sprite that is selectable and movable in animation // A sprite object is a sprite that is focusable and movable in animation
typedef struct typedef struct
{ {
Sprite* sprite; Sprite* sprite;
@@ -31,7 +31,6 @@ typedef struct
FIXED trotation; // this never gets used so i might remove it later FIXED trotation; // this never gets used so i might remove it later
FIXED rotation; FIXED rotation;
FIXED vrotation; FIXED vrotation;
bool selected;
bool focused; bool focused;
} SpriteObject; } SpriteObject;
@@ -58,8 +57,6 @@ void sprite_object_reset_transform(SpriteObject* sprite_object);
void sprite_object_update(SpriteObject* sprite_object); void sprite_object_update(SpriteObject* sprite_object);
void sprite_object_shake(SpriteObject* sprite_object, mm_word sound_id); void sprite_object_shake(SpriteObject* sprite_object, mm_word sound_id);
void sprite_object_set_selected(SpriteObject* sprite_object, bool selected);
bool sprite_object_is_selected(SpriteObject* sprite_object);
Sprite* sprite_object_get_sprite(SpriteObject* sprite_object); Sprite* sprite_object_get_sprite(SpriteObject* sprite_object);
void sprite_object_set_focus(SpriteObject* sprite_object, bool focus); void sprite_object_set_focus(SpriteObject* sprite_object, bool focus);
bool sprite_object_get_dimensions(SpriteObject* sprite_object, int* width, int* height); bool sprite_object_get_dimensions(SpriteObject* sprite_object, int* width, int* height);
+3 -2
View File
@@ -66,6 +66,7 @@ CardObject* card_object_new(Card* card)
card_object->card = card; card_object->card = card;
card_object->sprite_object = sprite_object_new(); card_object->sprite_object = sprite_object_new();
card_object->selected = false;
return card_object; return card_object;
} }
@@ -114,14 +115,14 @@ void card_object_set_selected(CardObject* card_object, bool selected)
{ {
if (card_object == NULL) if (card_object == NULL)
return; return;
sprite_object_set_selected(card_object->sprite_object, selected); card_object->selected = selected;
} }
bool card_object_is_selected(CardObject* card_object) bool card_object_is_selected(CardObject* card_object)
{ {
if (card_object == NULL) if (card_object == NULL)
return false; return false;
return sprite_object_is_selected(card_object->sprite_object); return card_object->selected;
} }
Sprite* card_object_get_sprite(CardObject* card_object) Sprite* card_object_get_sprite(CardObject* card_object)
-14
View File
@@ -320,20 +320,6 @@ bool joker_object_score(
return true; return true;
} }
void joker_object_set_selected(JokerObject* joker_object, bool selected)
{
if (joker_object == NULL)
return;
sprite_object_set_selected(joker_object->sprite_object, selected);
}
bool joker_object_is_selected(JokerObject* joker_object)
{
if (joker_object == NULL)
return false;
return sprite_object_is_selected(joker_object->sprite_object);
}
Sprite* joker_object_get_sprite(JokerObject* joker_object) Sprite* joker_object_get_sprite(JokerObject* joker_object)
{ {
if (joker_object == NULL) if (joker_object == NULL)
-15
View File
@@ -161,7 +161,6 @@ SpriteObject* sprite_object_new()
SpriteObject* sprite_object = POOL_GET(SpriteObject); SpriteObject* sprite_object = POOL_GET(SpriteObject);
sprite_object->sprite = NULL; sprite_object->sprite = NULL;
sprite_object_reset_transform(sprite_object); sprite_object_reset_transform(sprite_object);
sprite_object->selected = false;
sprite_object->focused = false; sprite_object->focused = false;
return sprite_object; return sprite_object;
@@ -277,20 +276,6 @@ void sprite_object_shake(SpriteObject* sprite_object, mm_word sound_id)
play_sfx(sound_id, MM_BASE_PITCH_RATE); play_sfx(sound_id, MM_BASE_PITCH_RATE);
} }
void sprite_object_set_selected(SpriteObject* sprite_object, bool selected)
{
if (sprite_object == NULL)
return;
sprite_object->selected = selected;
}
bool sprite_object_is_selected(SpriteObject* sprite_object)
{
if (sprite_object == NULL)
return false;
return sprite_object->selected;
}
Sprite* sprite_object_get_sprite(SpriteObject* sprite_object) Sprite* sprite_object_get_sprite(SpriteObject* sprite_object)
{ {
if (sprite_object == NULL) if (sprite_object == NULL)