* Updated all static variables to have the s_ prefix and constants to upper case
* Renamed missed sneaky functions in round.c (+ clang-format...)
* Renamed a few more missed constants
* Updated rng_update() documentation
* Apply suggestions from Copilot's code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Added missed suggestion
* Updated rng_update() comment
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Turned SpriteObject into a member of JokerObject and CardObject and expiremented with casting
* Extracted shop code to use generic `SpriteObject`
* Extracted shop joker generation to a function
* Renamed object -> item
* Added setters and getters for `SpriteObject` members and updated all accesses to use them with casting (AI used for tedious work and reviewed - model Raptor mini)
* Added sprite_object_set_vx() because sprite_object_set_vy() exists and reordered the function order to have x,y parameters first, then targets
* Added Item object to act as a purchasable interface for the shop - AI used (model Raptor mini)
* Added -fms-extensions and switched to anonymous inheritance
* Fixed anonymous inheritance for joker and added direct access for that too
* fix build error from previous commit + clang-format
* Fixed build errors + clang-format for real this time (I hope...)
* clang-format one last time, I don't understand it anymore
* clang-format is annoying
* Added uses of CHECK_NULL_ARG macros
* Merged item_defs.h into item.h and fixed build error from previous commit
* clang-format...?
* Changed sprite_object_new() into sprite_object_init() and made it accept a parameter instead of returning one to make it less awkward
* Updated sprite_object_init() documentation
* Updated sprite_object_destroy documentation
* More clang-format
* Renamed add_to_inventory to acquire and updated documentation
* Added function documentations
* Update documentation + swap order of consumable and playing card types
* Added documentation for new files (+ small addition to button.h)
* clang-format
* Used typedef
* A bit more documentation
* Changed sho pcode to use generic Item instead of SpriteObject
* clang-format + fixed NULL-check error
* Revert weird clang-format...?
* clang-format for real
* Fixed errors from rebase on log_function_name
* Fixed build errors from rebase on main
* Added some more documentation about first member struct inheritance
* typo fix
* typo fix for real
* Removed SpriteObject field getters/setters (AI used - model Raptor mini)
* Renamed item_acquire -> item_on_acquired
* Added item_can_acquire()
* clang-format
* Fixed some sprite issues but not all...
* Fixed some more issues
* Cleanup JokerObject some more JokerObjects in the shop
* Added `item_destroy()`
* Added item_set_available_to_shop, CHECK_ITEM_TYPE macros + small documentation updates
* Another small JokerObject->Item replacement
* Removed item_set_available_to_shop and replaced with item_roll_new() and item_dispose(), also changed "available_to_shop" semantics to "rollable"
* Re-applied changes from game.c to round.c after rebase on main
* Added partial implementations of item functions for playing cards
* Line endings fix...
* Macro renames, function documentations
* Updated documentations
* Apply fixes from Copilot review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Fix card_object_get_buy_price type checking
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Avoid double pointer cast on dispose
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Apply suggestions from @ricfehr3's code review
Co-authored-by: Rickey <ric@rf3.xyz>
* Remove redundant comments
* Moved error checking before joker_get_random_rarity
Co-authored-by: Rickey <ric@rf3.xyz>
* Fixed build error from rebase
* clang-format
* Added doxygen documentation for Item explaining inheritance
* Removed unnecessary comment
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Rickey <ric@rf3.xyz>
* Added function name logging to mgba_logger
* Addendum to no-op defines
* Fixed compile errors
* Added "()" to function name in log to make it clearer it's a function
* Corrected documentation
* clang-format...?
* Removed MGBA_LOG_LEVEL_MASK magic number
* Added CHECK_NULL_ARG macros
* clang-format...?
* clang-format for real
* Added documentation for CHECK_NULL_ARG_VOID and CHECK_NULL_ARG_RET
* Fixed typo
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Fixed macro safety by wrappinh with do-while
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Fixed format string cut risk in mgba_func_printf
* clang-format
* clang-format some more
* clang-format for real
* Fixed DEBUG -> INFO in comment
Co-authored-by: Rickey <ric@rf3.xyz>
* Moved NULL-check macros to util.h and renamed them
* Small additions - macro rename + clang-format
* Truncate the string instead of the function name
* Cleaned up code from previous commit
* clang-format
* Added mgba_logger_available check to mgba_func_printf
* Updated documentation for latest change
* Changed CHECK_NULL_ARG functions to generic RETURN_ON_ERROR_VAL functions.
* clang-format
* Changed back to specifically check NULL
* clang-format
* Changed "=" into "==" in the error message
* clang-format
* Fixed forgotten "=="
---------
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Rickey <ric@rf3.xyz>
* Music - copied echo melodies from old branch `music_past_echo_triads`
* Music - increased volume and panning of panned echo triads
* Music - compatibility save
* Music - reduced the bolume of panned echo triads back but kept the panning
* Music - added note cut at the end of marimba climbs + increased the volume of the background drone a bit
* Music - added up to measure 54 - finished echo leads
* Music - Fixed backing error in the echo leads (missed subdominant section)
* Music - Fixed backing drone crescendo
* Music - Made the backing drone a bit more subtle
* Music - Improved last lead echoes
* Music - Finished last measures mallet arpeggios + added crash cymbal in the beginning
* Music - removed crash cymbal in the beginning, doesn't sound good compiled
* Music - Reduced first marimba arpeggios by one octave
* Music - Added subtle crescendo in dotted eighth scale walk
* Music - reduced volume and added crescendo to the drone in the beginning
* Music - Increased the last echo lead by an octave
* Music - Switched the panning of the last panned echo triad so it correctly alternates
* Music - Fixed panned echo triads panning inconsistencies
* Music - Added portamento and note stops to the lead melody
* Added OpenMPT .bak files to .gitignore
* Music - Expanded the module 2x for more accurate quasi-triplet + added 2-3 measures
* Music - Added pitch bend and fixed decorative note
* Music - Added measures 31-32
* Fixed wrong G/D chord sample
* Music - added measures 37-38
* Music - Added echo quasi-square
* Music - layered the quasi-square with the keyboard
* Music - small reduction to quasi-square volume
* Music - more volume adjustments
* Music - added measures 39-32 (triad chords)
* Music - raised the triad chords one octave
* Added missing repetition measures 33-36
* Music - More repetition measures 43-46
* Music - fixed pitch bend in measure 30
* Music - Added tremolo to the lead synth
* Revert "Music - Added tremolo to the lead synth"
This reverts commit 3ffee4684521989501239fbfae6b1276bf713818.
* Music - reduced the triad chords by an octave
* Music - Added lead melody fade-out and reduced triad chords volume
* Music - Added channel 7, and unused channel 8
* Increased the triad chords volume back
* Music - Added panned backing chords (used all 8 channels)
* Music - Added all the panned backing chords
* Music - fixed last echo note
* Music - Added background fifth drown to triad chords
* Music - reduced panning of panned chords
* Updated music arrangement credits in README
* Changed L and R keys to play and discard respectively, removed sorting key in favor of on-screen buttons
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Added definitions for sorting buttons (cherry pick, does not compile)
* Re-applied changes lost in merge
* Added sort buttons functionality (cherry-pick, has issues)
* Fixed sort buttons issue
* Removed stray code from merge
* clang-format
* Removed code from merge error
* Removed unused function from merge error
* Removed "E" typo from "SUIT" button
* Changed all the 2x5 S's in the UI to be 1 pixel wider at 3x5
* Revert "Changed all the 2x5 S's in the UI to be 1 pixel wider at 3x5"
This reverts commit f70e0d5ab76dd851c564672c01ab60cd25c28b63.
* Changed the width of the "SUIT" button to be consistent with the "RANK" button
* Fixed to truncate as "1.234M" instead of "1234K"
* Optimized by switching to strings to avoid divisions
* Changed FP constants to strings
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Change selection grid to maintain relative horizontal position when switching rows
* clang-format
* Fixed joker selling index error
* Protect against division by 0 and removed redundant fixed point conversions.
* Added C standard gnu23 to the makefile
* Added gnu23 standard to all test modue makefiles
* Added installation of latest gcc version to tests workflow
* Fixed typo in previous commit
* Made GCC 14 installation conditional and moved from the workflow to the script
* Extracted GCC version check to external script for CI and created tests README
* Added #!/bin/bash
* Make check_gcc_version.sh executable
* Fixed score truncation erasure, and centering for chips, mult, score and "temp score
* Added centering for money
* Added tests for truncate_uint_to_suffixed_str()
* Fixed u32 bug with get_digits
* Fixed score flames for large numbers
* Small change to update documentation
* Added 1 pixel on to score rect on the left to make room for full character tile + reset_top_left_panel_bottom_row() refactor
* Replaced directional defines with enums
* Updated ante_lut comment
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Added art for Jokers Bootstraps by @MathisMartin31 and @noctowlhoot and Pareidolia by @NoWhammies10 and @MeirGavish (jokers rearranged for palette optimization)
